Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid slashes in names of Groups and Datasets #1219

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Forbid slashes in names of Groups and Datasets #1219

wants to merge 2 commits into from

Conversation

bendichter
Copy link
Contributor

  • add checks to ensure that name and default name args do not contain slashes.
  • include tests

Motivation

We want to make sure people don't create extensions that contain names or default names that contain slashes.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@bendichter bendichter requested a review from rly December 12, 2024 12:07
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.82%. Comparing base (d1d1b5a) to head (578dba2).

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #1219   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files          43       43           
  Lines        9524     9528    +4     
  Branches     2723     2725    +2     
=======================================
+ Hits         8650     8654    +4     
  Misses        580      580           
  Partials      294      294

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly mentioned this pull request Dec 12, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rly rly Awaiting requested review from rly

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bendichter